jbraeuer/phantomjs-rpms — pull request #3 by kaiinkinen (2012-01-19 20:42:55+00:00)
Title: Spec files for building phantomjs 1.4.0 and 1.4.1. Sources need to be downloaded using the fetch-phantomjs-branch

Hey!

I created a new for of the repository, to change the original pull request. I added myself to the changelog. However, the

basedir=$(cd $(dirname "$0"); pwd)

"hack" is in place to convert the path into an absolute one. It will not actually change the working dir, as the command is executed in a separate, independent subshell. If just doing 'dirname "$0"', the returned path will be relative, which can cause some problems if changing working directories back and forth during script execution. In general I think it is safer to use absolute paths, if possible.

This does not quite do the same as 'readlink' on linux would, but the functionality is quite cumbersome to include in the scripts:

http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac

Anyway, if you feel strongly that having absolute paths is unnecessary, I can do the change you suggested.

br.
.kai.inkinen