UnionOfRAD/lithium — pull request #261 by dgAlien (2012-01-11 22:50:19+00:00)
Title: Fixing most lithium_qa issues

Did a qa on my project including the lithium lib and realized, that they are some qa issues..

So i fixed most of them. There are four left (in reverse order)

- [Failed ] syntax check of `data/source/MongoDb.php`

553| 101| Maximum line length exceeded

this is quite difficult to fix because of an inline filter definition

- [Failed ] syntax check of `data/source/database/adapter/my_sql/Result.php`

12| 1| Dependency `PDOStatement` declared but not used

PDOStatement is used but in instanceof() , which should be better is_a()

151| 3| No brace for `if` statement

```php
if ($this->_resource instanceof PDOStatement
&& $this->_iterator < $this->_resource->rowCount()
&& $result = $this->_resource->fetch(PDO::FETCH_NUM)) {
return $this->_cache[++$this->_iterator] = $result;
}
```

any idea?

- [Failed ] syntax check of `data/entity/Document.php`

114| 4| var_dump() statement

it seems nate is working on it (he was the last editor of the line..

````
if (isset($this->_embedded[$name]) && !isset($this->_relationships[$name])) {
$item = isset($this->_data[$name]) ? $this->_data[$name] : array();
var_dump($this->_relationships[$name]);
die('#WINNING');
// $this->_relationships[$name] = $this->_relate($this->_embedded[$name], $item);
}
```

Maybe a throw NotYetImplemented() would be better ;)