joliver/EventStore — pull request #92 by tt (2012-01-08 12:59:06+00:00)
Title: A property of type `ConnectionStringSettings` is defined on `IConnectionFactory`

I was looking to implement my own `IConnectionFactory` which exposed a leaky abstraction:
The interface defines a property of type `ConnectionStringSettings` directly associated to the single implementation of the factory, the `ConfigurationConnectionFactory`.

I decided to change the constructor hierarchy to let the responsibility stay inside the `SqlPersistenceFactory`, but I guess you could also more it to the `IConnectionFactory`, so it itself would resolve the desired `ISqlDialect` implementation. I guess my approach will cause the least breakage.

(Note: I'm a big fan of incremental commits, so if you review them one by one, every refactoring should be expressed in a readable manner; to still keep a note of the branch's intent, use `--no-ff` when merging.)