joomla/joomla-platform — pull request #676 by pasamio (2011-12-27 11:42:23+00:00)
Title: Updates to fix updater system

This pull request:

- fixes CLIENT undefined index problem
- remove an undefined index warning
- removes the INFOURL addition until CMS has accepted the change
- and also removes a commented debugging statement that somehow made it in.

# "CLIENT" undefined index warning
In pull request 667 the concept of changing "CLIENT" to "CLIENT_ID" is introduced to remove an undefined index "CLIENT" problem. This is actually a side effect of CMS tracker 24338 [2,3] where the appropriate entry in the update_cols was mercilessly renamed from "CLIENT" To "CLIENT_ID" leading us to the predicament we presently find ourselves in.

I suspect that the initial change is itself a reaction to CMS Issue # 24305 [4,5] which goes to show the law of unintended consequences is truly afoot.

# Undefined index warning
An extra guard is added around the last_check_timestamp check in the update cache code that was added. There are situations when this value may not exist and could trigger a warning.

# Removal of INFOURL addition
The removal of the "INFOURL" tag is two fold. First it's in the wrong place, it should live in the _update_cols of the updateadapter class. Secondly until the CMS accepts the DB schema change[6], it breaks loading extensions which made the changes in this pull request rather hard to test using the current Joomla! 2.5 beta. Given this change was merged into the platform in July and it is now December, it is like that the CMS is presently broken but people just don't realise (the collection type is unaffected).

Refs:
[1] https://github.com/joomla/joomla-platform/pull/667
[2] https://github.com/joomla/joomla-platform/commit/28819069e156bb749371a0d08c30d1d7cd62a366#libraries/joomla/updater/updateadapter.php
[3] http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=24338
[4] https://github.com/joomla/joomla-platform/commit/120f114471ebd2842aa72a8d3958aa09525aeb16
[5] http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=24305
[6] http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=26635