SpringSource/spring-social — pull request #35 by michaellavelle (2011-12-24 01:35:44+00:00)
Title: Make ConnectController and ProviderSignInController more extendable

It would be really useful to be able to extend ConnectController and ProviderSignInController to add custom callback methods. For example, the callbacks from LastFm's api are neither OAuth1 or OAuth2 but are similar (using a different request parameter name). Adding new callback methods means requiring much of the functionality of the existing callback methods, but the existing callback methods use private helper methods and attributes. Making the visibility of these helper methods and attributes protected rather than private would make extending these controllers easier.

See

https://github.com/michaellavelle/spring-social-lastfm-non-oauth-web/blob/master/src/main/java/org/springframework/social/lastfm/nonoauth/connect/web/LastFmNonOAuthSignInController.java

for an example of this use case.

This controller extends a custom controller class

https://github.com/socialsignin/spring-social-web-non-oauth-extension/blob/master/src/main/java/org/springframework/social/connect/web/ExtensibleProviderSignInController.java

but could simply extend the existing ProviderSignInController if these visibility modifications were made.