polotek/libxmljs — pull request #90 by shtylman (2011-12-20 20:12:47+00:00)
Title: new version code review

Doing this a pull request so that it can be reviewed easily. I have gone through and cleaned up the patches from my major refactoring work. Each commit is a bit more independent now and I tried to keep tests passing after each commit.

This brings in the api changes which @polotek and I discussed on IRC. I have also turned the Sax[Push]Parser into event emitters to be more consistent with how node code is written.

The first few commits are small with the largest refactoring commits coming at the end.

The c++ codebase style is still a bit wonky (some places I started to use 4 spaces vs 2, and the braket style is different), but I did not want to muddy this pull request with giant syntax cleanup commits.