TheCount/score — pull request #3 by hexmode (2011-12-17 04:57:49+00:00)
Title: Fixes from Brian Wolff

* $wgLilyPond needs to default to something even if we expect user to
set it.

* Make $wgScoreTrim default to $wgUseImageMagick. I didn't like the
check to error out if $wgUseImageMagick was false, because someone
could have ImageMagick installed, but not want to use it for image
rendering.

* Switch the checks done in ParserFirstCallInit to be in the main
rendering code since returning false from ParserFirstCallInit is a
_really_ bad idea. It stops all other extensions from loading, and
the end user won't know why.

This also means that we only check if $wgLilyPond is executable when
we actually have tags to parse.

* For messages: since this is a parser hook, the messages are stored
in the parser cache, so we have to use the wiki's content language,
not the user language or the next person will get errors in wrong
language.

* Some of the messages should use parameters. This is especially
important for the "Page: 1" message, since that message may need
plural processing and digit conversion in some languages.

* Wrap most of the error messages in . This is the
convention for error messages, and makes them red.

I didn't do that for the compile-error message. But perhaps it
should also be put in the , at least for the intro
part.