glejeune/Ruby-Graphviz — pull request #33 by ronen (2011-12-11 20:23:22+00:00)
Title: Removed definition of Array#all? from core_ext.rb

I don't know why core_ext defines Array#all? since Enumerable#all? does the same thing (in MRI 1.8.7 and 1.9.3)

Except that this extension doesn't support the behaviour that "If the block is not given, Ruby adds an implicit block of {|obj| obj} (that is all? will return true only if none of the collection members are false or nil.)" http://www.ruby-doc.org/core-1.9.3/Enumerable.html#method-i-all-3F

So with this definition, including ruby-graphviz breaks any existing code that calls an_array.all? without a block. (Not hypothetical -- I updated my project to the latest version of ruby-graphviz and my project broke!)

And without this local extension, the tests seem to pass anyway (again, in MRI 1.8.7 and 1.9.3).