fog/fog — pull request #646 by meceo (2011-12-09 14:51:16+00:00)
Title: add query options for s3 to support response headers overwriting

Hi guys,

We are using your library (together with Carrierwave gem) in our project and I would like to thanks for that. Great job!

Carrierwave uses Fog::Storage::AWS::File#url, Fog::Storage::AWS::Files#get_https_url and Fog::Storage::AWS#get_object_https_url methods to get url. Unfortunately those methods do not support query params such as "response-content-disposition". I have to added that.

It was quite difficult for me to follow your test convention on this project and I had not found any unit test for those methods. Another problem is that tests were not passing on my local before I've changed anything, but that can be related with some missing configuration on my side. Therefore I have not added tests for that.

In the same time I am creating a pull request for carrierwave project to accept my change to "url" method. Carrierwave would require first changes on fog to work correctly, that's why I have left in carrierwave's Gemfile dependency to fog forked on autohaus24.

Please let me know if the changes are on acceptable level or there is anything that could be done better

Best regards,
Mateusz Juraszek
autohaus24.de