davidiw/Dissent — pull request #3 by henrycg (2011-12-08 22:13:07+00:00)
Title: Request for comments on test code

Hi David,

I spent this afternoon writing up some tests for the Web services. I tried to follow the test conventions where they exist, but I might have screwed it up. Can you take a look through here and let me know what you think?

Also: I changed SessionWebService services to use QSharedPointer -- not QSharedPointer, as you had made. My thinking is that it's better to give services the more restrictive access to session, and create NodeWebService for those ones that really need access to the whole node. Also, since the tests use TestNode, it makes it much easier to test Session services than Node services (since Node != TestNode). I can change it back if it's a big deal.

On the agenda for the next days/weeks:
* WebServer tests
* README write-up
* Ubuntu 10.04 LTS compilation

Henry