pioneerspacesim/pioneer — pull request #844 by Luomu (2011-12-07 20:22:23+00:00)
Title: Starfield updates

- I moved the background elements out from Camera so they are not duplicated for each camera! I think Space is the more correct home for them.
- Starfield is now updated every time a new system is entered. Previously it stayed same.
- I also squeezed the starfield a bit so there is more density near the milky way strip - looks better! If you want to, try with different scale factors. I think maybe 0.3-0.4 with less stars (even 10 000) is better but I didn't change it too dramatically).
- Some small cleanups.

Would be nice to figure out the correct rotation of the milky way strip (with regards to Earth, other systems don't matter). Background intensity could also change depending on distance from the center of the galaxy but I don't know what would be sensible numbers.

As a side effect the hyperspace effect lines are no longer based on the system you are jumping out of - hyperspace has its own Space so the background is recreated. It could be hacked around by passing the previous system seed to Space constructor, but I'm not sure if it's a big deal. What's the logic of the effect anyway (besides copying star wars)? The lines have never matched the arrival system either.

I did this on top of space-refactor again since it's cleaner... so merging this will have to wait, but I opened the request for feedback anyway.

I'm not entirely sure of the last commit, 05921fb95ac8c6899f524b76567e0afe2ac9fa99, I felt it needs some sort of a single container but couldn't think of a better name.