bcwaldon/python-gerrit — pull request #1 by MHordecki (2011-12-06 22:21:59+00:00)
Title: Loads of new functionality + basic testing.

Hi!

Unfortunately I've thought about proper commit separation waaay too late. Also, many of those changes are more or less codependent. Given that, I'm submitting the whole thing as it is and maybe we can do some kind of code review. I this comes through, rest assured that next pull requests will be much more sane :) (also more focused on code quality - this pull request is mostly a result of intense one-day hacking)

Some comments about the code:

* I've moved client.Gerrit to rpc.Client in order to streamline the API, as I've added additional means of interaction with gerrit: db.Client (database) and raw.Client (raw filesystem) (they are needed for some rather important functions, such as project creation/removal).
* I've moved decoding functions to a separate file.
* RPC client is now stateful - it's required for authentication.
* The whole test suite is rather brittle and incomplete, but I think it's a good start.
* I've tried to emulate your coding convention, with one exception - blank lines after class declaration make my eyes bleed.