puppetlabs/puppet — pull request #243 by daniel-pittman (2011-12-05 08:28:01+00:00)
Title: maint/2.7.x - the little indirector cleanup that didn't

A little over a year ago the first step in a series, planned to clean up the indirector, was committed to the tree. It extracted some of the mixin behaviour of indirection and replaced it with access through an explicit accessor for the indirection class.

The plan itself was good, but delivery never came, and for the last year we have carried the burden of this partially completed work - a burden of incompatibility between the 2.6 and 2.7 series, and a burden of extra ceremony every time an indirected model was touched.

This series undoes that change, and performs some minor cleanup to get this back into a pleasant and easy to use - and 2.6 compatible - form.

In the event we do decide to again go down the path of the cleanup, this is not too onerous to extract again. In reality, the odds are that the form of the cleanup would, today, be different to the form a year ago as more of the code has moved, and the overall architecture is no longer envisioned the way it once was.

There are no substantial functional changes in this, but there are some minor cleanups to unify interactions with terminus configuration in the model classes, and to ensure that we have less ways to do the same thing overall.