oalders/http-browserdetect — pull request #27 by obilodeau (2011-12-01 15:32:31+00:00)
Title: internally categorizing tests in types

I've categorized the tests in logical groups. This was already done except that it was in logically grouped "push" instead of separate variables.

This prevented me from tying deeply into your module to benefit from that organization. We did that a few months ago[1] and we shipped the code[2] including some bits to report 'unknown' UA.

I know I'm cheating by binding directly into your module's variable and skipping proper encapsulation but I think at this point there is no benefit for you or your users to expose these and I might come up with a good interface for it later on. If you have a better idea I would be interested to know and I might even implement it for you.

Merging this would reduce the overhead of me having to track your changes. And I think I've been careful not to introduce any burden or issues to the code.

I'll be adding 'unknown' UA to the test suite starting from tomorrow.

[1] http://mtn.inverse.ca/revision/file/9f43636d3401f2b2473ffcaa964a559d36e67694/pf/lib/HTTP/BrowserDetect.pm
[2] http://mtn.inverse.ca/revision/file/9f43636d3401f2b2473ffcaa964a559d36e67694/pf/lib/pf/useragent.pm