benatkin/wordpress-myopenid-delegation — pull request #1 by guss77 (2011-11-30 17:08:57+00:00)
Title: Improvement suggestion for your myopenid delegation plugin

Hi Ben Atkin.

Here's a suggestion for improvement in your OpenID delegation wordpress plugin by replacing the dependency on MyOpenID with a framework to support multiple providers.

Here's some background to explain why I needed that: I wanted to use my blog as an OpenID login, and I was using MyOpenID as a delegate by hard-coding the required meta-tags in the header.php of my main theme. Later I wanted to change my provider to Google Apps, and decided its a good time to bring in a more "correct" solution. Searching the web for a plugin that adds the required tags automatically, I came across your script - but as it only supports MyOpenID it wasn't exactly what I needed. An hour of tweaking PHP code later and now it has an option of selecting the provider to be used.

I've changed some stuff around in the meta-tags writing function that is not really about support but more about code-style (I didn't like the single-quote delimited strings that must be catenated with with a double-quoted string for a new line, so I did something else, and also converted the nested if to a "fail fast" scenario - as I think its better).

Anyway, I'd appreciate any comments on my changes.