libgit2/libgit2 — pull request #504 by arrbee (2011-11-30 21:21:20+00:00)
Title: Optimized implementation of git_buf_join

This update streamlines git_buf_join and removes the join-append behavior, opting instead for a very compact join-replace of the git_buf contents. As an extra benefit, if separator == 0, this now just joins the two strings into the buffer.

The unit tests had to be updated to remove the join-append tests and have a bunch more exhaustive tests added.

I'm pretty pleased with how the compact version turned out. What do you think?