concrete5/concrete5 — pull request #280 by jordanlev (2011-11-27 06:22:43+00:00)
Title: changed the direction of up/down arrows for dashboard "advanced options"

I think the up/down ("expand/collapse") arrows next to "Advanced Options" in various dashboard pages (e.g. File Manager, User Search) should indicate what clicking the button does, not indicate what the current state is. Right now, when Advanced Options are hidden, the arrow points "up", to indicate that the options are hidden -- but this pull request changes that so when Advanced Options are hidden, the arrow points "down", to indicate that clicking on the button will expand the advanced option controls. I feel that this is more intuitive, because the fact that the advanced option fields are visible is enough indication that they're being shown -- the arrow itself has more to do with the expansion/collapsion action as opposed to the current visibility of the advanced fields.
But I realize this is somewhat subjective so maybe it's just me :)