Aldriana/ShadowCraft-Engine — pull request #94 by dazer (2011-11-26 17:27:13+00:00)
Title: 4.3 update

I included some of the basic new procs. It needs testing and tweaking so it's only a legwork (the computer in which I code died on a fire so to spek).

No'Kaled, the Elements of Death (http://ptr.wowhead.com/item=77188): ICD seems to be 2'' (http://worldoflogs.com/reports/rt-9r2wd7p5x7f9a952/xe/?x=sourcename+%3D+%22Goombamfx%22). Reports from the ptr state that it only procs from strikes/swings done with the weapon (no KsP/Mut oh component or oh white swings in our case). It can proc 3 different spells (iceblast, shadowblast, flameblast 1/3 chance each), but given rogues don't have different modifiers for these spell schools we souldn't bother much with that. This weapon has gone through several changes in ptr; I'm taking the proc chance from the simulationcraft revision prior to the proc being included in the DBC (which is a hard-ish to read file). It's very likely that it'll be a ppm proc, but with only one log I cannot verify such thing, I believe. It's ep is otherwordly high as is but it should get lower once we code the weapon restriction (maybe having it as a weapon enchant?)

Wrath of Unchaining (http://ptr.wowhead.com/item=77197): Coded just like Fluid Death.

Kiroptyric Sigil (http://ptr.wowhead.com/item=77113): It's a VP reward, so heroic/lfr versions won't be available on live; however, seeing as the front-end picks these items regardless of availability, I'm coding them in.

Starcatcher Compass (http://ptr.wowhead.com/item=77202): ICD is taken from latest build of SimulationCraft (which asumes icd equal to the caster trinket insignia of corrupted mind, since both trinkets point to the same proc id).

Vial of Shadows (http://ptr.wowhead.com/item=77207): http://www.worldoflogs.com/reports/87cwp7i2248y3ty9/xe/?x=sourcename+%3D+%22Dragonnztoo%22%0D%0Aand+spell+%3D+%22Lightning+Strike%22 suggests a 25'' icd. Reports state that the strike scales with AP (adding one damage per AP point); if that's the case we may need to revisit or special case how physical procs are computed.

Legedary dagger set: We don't know yet the behaviour for the stage3, so I only included the stackign buff for 1st and 2nd stages. Note the use of the behaviour toggle implemented for enchants: it sets a different proc rate based on spec. I included a new gear buff to deal with the odd posibility of equiping only the MH, thus getting the SS/RvS buff (if combat) but not the stacking agi proc. More tests will be needed, so everything legendary related is rather placeholder-ish.