nbudin/heroku_external_db — pull request #7 by benjaminoakes (2011-11-21 20:09:47+00:00)
Title: X.509 Support

Hi Nat,

As promised, here is X.509 support. If you could, we'd appreciate it if you could release a new version of the gem (e.g. "v1.0.2") to RubyGems so we can use an "official" gem rather than a vendored one. Of course, if you have any questions about the changes, please let me know; I'll be happy to address them.

I've tested the new version of the gem using a tiny Rails 3.1.2 app and I can confirm that the X.509 support works. I also TDD'ed the specs for the new functionality (rather than just hacking it in to see if it could be done, like I did on Friday). All the specs pass on my machine; please let me know if you have an issue.

However, I can't easily test a configuration with just a CA certificate as we don't have a server set up for that. Before release, I would recommend double checking that I didn't inadvertently break behavior that wasn't covered by the specs.

Thanks again for helping us out by making the gem.

One last thing: from looking at your profile, I noticed you're not too far away from us (we're in New Haven, CT). As the organizer of newhaven.rb, I'd like extend an open invitation to stop by one of our meetups if you're ever in the area. We have a pretty active Ruby community and always enjoy meeting new people. For more info:

* http://newhavenrb.org/
* http://www.meetup.com/newhavenrb/

Best wishes,

Ben