broofa/node-uuid — pull request #17 by ctavan (2011-11-19 13:38:10+00:00)
Title: V1 uuid finetuning

Hi Robert,

thanks for giving me the chance to go through your changes once again! All in all it looks really nice and clean now, you did a good job in cleaning up uuid.js again.

I have only few remarks:

1. The `_count == UUIDS_PER_TICK` thing I've also commented on your commit.
2. I'm not so happy with the choice of `time2`. I'd prefer a name that gives at least some clue to the developers before they need to RTFM.... I've changed it to `timesubms` which is maybe not nice either, but at least it says what it is... Maybe you have a better idea, but `time2` I don't like.
3. I personally don't like declaration of multiple variables in one line like `var buf = buf || new BufferClass(16), i = offset || 0, ii = 0;` especially if there are ||-conditions involved. But that's just my personal preference. If you prefer it that way, please just ignore my changes.

I also really like your tests in options.js

Cool thing all in all!

I've just done some interesting benchmarking against node v0.6.2, I'll push my results in a second :).