JoomFish/jf-future — pull request #1 by quodo (2011-11-19 12:06:16+00:00)
Title: Some changes on JFish for J!1.7

Hi Alex,

See "Developers version on Github" topic in "Joom!Fish 2.6 for Joomla 1.7+" board (http://www.joomfish.net/forum/viewtopic.php?f=48&t=10770) for some history. Alex wrote there
"If we get a pull request from you in the end this is perfect".

I just could not resist... learn git and get you an easy way of reviewing the changes mentioned in my post.

In short these are the changes I made after I forked your jf-future (https://github.com/quodo/jf-future):
^ moved component language files for admin --> xml description gets translated during install when language files are in admin/language/en-GB/....sys.ini, moved other language files there as well (perhaps .menu.ini can be removed?)
^ changed manifest to reflect that move
^ changed mosPageNav to JPagination (2x) --> this was legacy (J!1.0) pagination
^ ElementsController task now protected instead of private --> not sure about this (!), should more vars be protected instead of private since the parent class holds protected vars and not private ones

With these changes the main errors are gone, but I cannot translate anything and JoomFish thinks everything is translated. See http://www.joomfish.net/forum/viewtopic.php?f=48&t=10770#p36964 on that. I think it has something to do with id's that are available when they shouldn't be (e.g. no translation in database table). It works differently in this 3.0.0alpha than in the 2 version that I have on my computer (checked with Eclipse). I'd love to test further when that's fixed though.

With kind regards,
Mirjam (username quodo)