laughinghan/choreographer — pull request #6 by lodewijkadlp (2011-11-13 14:25:50+00:00)
Title: GET arguments passed to callbacks as arrays.

Pretty much that. Any statement that ended with a ? wouldn't route properly. I thought it was a bug but it might've been a design decision. Either way to preserve backwards compatability I've made choreographer push the GET arguments (?foo=bar) to the last argument in a callback. Callbacks now look like:

function(req, res, [arg1, arg2 ...], args){ }

This way there's no static amount of arguments, there's backwards compatibility and it's easy to use. It might still be confusing for people new to choreographer though, even though it's documented. It also slightly complicates choreographer, it doesn't make it do any new tricks though. Just completes it a little more.