jrconlin/oauthsimple — pull request #12 by JoeCianflone (2011-11-04 18:58:57+00:00)
Title: Feature to php5 and other GC updates

We've been using oAuthSimple in a project at my job. We made some modifications and wanted you to take a look at them and see if you wanted to port any of them back into your version.

1. Removed the in code example...not necessary since you have an example already in the file that comes with this
2. Moved the copyright notice to another file...it's a pretty big thing in the code and seems unnecessary to me if you happen to have another file that you can use
3. Updated the copyright date to 2011
* Side note: I think you should remve the "All Rights Reserved" part. You've put this on github for anyone to freely fork. It just doesn't make sense to me.
4. Incremented the version number to 1.3
5. Changed the URL to point to the github repo
6. Put in a basic OAuthException class that does something
7. Moved the Exception class to the bottom of the page
8. Removed closing ?> which could cause trouble if someone put's in a extra space after that close
9. Converted all functions to use PHP5 public/private syntax
10. Put braces around all IF statements and generally made the code a little more readable
11. BUG: We fixed a bug in the normalizedParams function, it's probably an edge case, but if you have keys that look like this key["keyval[1]"] it would not sort correctly if you had more than 9 of them
12. updated phpDoc styles