xbmc/xbmc — pull request #510 by CrystalP (2011-10-25 01:03:31+00:00)
Title: Add subtitle option to override the ASS/SSA subtitles font - work around ass fonts problems

Add an option to make libass use the font specified for srt subs with the ass/ssa subtitles rendering, instead of using the services of fontconfig and the fonts embedded in mkv files. That typically means using arial.ttf

This is both a bug work around and a new feature:
- bug fix, as it allows users to work around any weirdness that happens with the font selection issues noticed in ticket 12023 and described in team forum thread. This option also provides a way out in case the upcoming fix for fontconfig cache issues has unexpected side-effects. I checked that this PR works for all samples that otherwise fail.
- new feature, as it allows overriding the sometimes hard-to-read fonts specified and embedded in some mkv. It's possible to expand this feature later and also use the srt size/style/color values (with libass style overrides)

Works by preventing libass from using fontconfig and specifying the default font.
When disabling fontconfig, it's 100% correct to call ass_set_fonts with update=0.

This is low risk for Eden. What do you guys think, in or out?