jenkinsci/jabber-plugin — pull request #5 by meonkeys (2011-10-23 05:51:32+00:00)
Title: Fix for JENKINS-11443 - E-mail address as Jabber ID config setting.

(same patch attached to JENKINS-11443)

null was being returned by getConfiguredIMId() when
* user's jabber ID was not set
* user's email *WAS* set
* setting "E-mail address as Jabber ID" was enabled

It should have been returning the user's email address.

This patch fixes the configuration setting "E-mail address as Jabber ID"
when the conditions described above are met. The setting can be found
at /configure under "Advanced..." for the Jabber Notification plugin.

During testing I didn't receive any messages from the Jenkins Jabber
robot, but this was probably just a misconfiguration in my local testing
environment. The bot did reply to me when I directly IM'ed "!status" or
"!build test" or whatever, it just wouldn't send automatic
notifications. I was using two different users on jabber.org, one was my
real ID, another was made just to test this patch. I debugged using
Netbeans and (other than not receiving any automatic Jabber notification
IMs from Jenkins) the code appeared to work as expected after adding the
null check.

Hope this helps!
-Adam