walle/gas — pull request #6 by TheNotary (2011-10-22 17:50:56+00:00)
Title: Fixed a bug when using ssh

Hey again

When connected to unix via ssh, the add-ssh command returns 2 instead of 0, and so it would pump out an error. This doesn't seem to have any negative repurcussions on the program (it's a bit mysterious that it is this way too) so I just rewrote the error message to only pump out when ssh-add returns 1 (which means it failed).

I also changed it so you can hit ctrl+c and it will exit the program with out spewing out a lengthy error and the callstack.

------------------------------------

No progress on the test yet... I suppose I should add a parameter to all of the many methods that involve file manipulation... the parameter would be named 'is_testing' and we'd set it to true when we're actually testing, else default false? Then test this param and if it's true, use TEST_GAS_DIRECTORY and TEST_SSH_DIRECTORY instead of their normal counterparts?

All the little parameters seems a tad messy to me --Gas.add(nickname, name, email, is_testing) seems like a bit of a shame. What do you think about this approach?