n8han/Databinder-Dispatch — pull request #53 by ostewart (2011-10-17 15:38:07+00:00)
Title: Specify make_client return type to allow override

Scala narrows the return type of an overridden method to the inferred type of the overriding method. This prevents subclasses from further overriding according to the original type, HttpClient. Specify HttpClient explicitly so that any subclass can override make_client.

I think I saw somewhere that this change had been made to one of the classes that overrides make_client. There are still a few overriders (nio.Http, gae.Http) that use the inferred type that should presumably also get this change. I only updated the one we're using and added a test for it (that only checks that it can compile, really).

Thanks,
Oliver