joomla/joomla-platform — pull request #430 by elkuku (2011-10-17 21:08:05+00:00)
Title: Sniff fixes

This will

* Fix the else and elseif sniff
* Fix the standard for multi line function declaration
* Fix the standard for multi line if declaration as discussed in #424 and requested by @eddieajau
* Fix the last line empty sniff not working in classes
* Remove the "File is being conditionally included" sniff as suggested by @LouisLandry in #424

(Includes unmerged changes from #425)

### Result

```
phpcs -np --standard=build/phpcs/Joomla/ libraries/joomla
............................................................ 60 / 305
............................................................ 120 / 305
............................................................ 180 / 305
............................................................ 240 / 305
............................................................ 300 / 305
.....

Time: 47 seconds, Memory: 14.25Mb
```

which means there are no more **errors** - *hooray* - Could we include the sniffer in the process of approving pull requests and reject code that doesn't meet the standards ? (this will also prevent further annoying pull requests changing white space only ;) )

BTW: There are still some
### Warnings

```
------------------------------------------------------------------------------
SOURCE COUNT
------------------------------------------------------------------------------
Joomla.NamingConventions.ValidVariableName.PublicUnderscore 234
Joomla.NamingConventions.ValidFunctionName.PublicUnderscore 168
Joomla.NamingConventions.ValidFunctionName.NotCamelCaps 24
Generic.Files.LineLength.TooLong 14
Joomla.NamingConventions.ValidFunctionName.ScopeNotCamelCaps 10
------------------------------------------------------------------------------
A TOTAL OF 450 SNIFF VIOLATION(S) WERE FOUND IN 5 SOURCE(S)
------------------------------------------------------------------------------
```