ipython/ipython — pull request #887 by fperez (2011-10-17 08:56:09+00:00)
Title: Qtconsole menu

This PR is meant to continue the work started by @Carreau in #813, which was sadly interrupted by a mugging. Since we don't know when @Carreau will be able to resume regular work, I've rebased his branch on top of master (at his last commit it had a small conflict), and I'm putting it up here on a common branch that several of us could in principle work on.

Unfortunately, when this happened the branch was actually in a broken state, because the qtconsole doesn't start, failing with:

/home/fperez/usr/lib/python2.7/site-packages/IPython/frontend/qt/console/qtconsoleapp.py in init_window_shortcut()
1134 statusTip="Toggle menubar betwin visible and not",
1135 triggered=self.toggle_menu_bar)
-> 1136 self.window_menu.addAction(self.toggle_menu_bar_act)
1137
1138 def toggle_menu_bar(self):
AttributeError: 'IPythonQtConsoleApp' object has no attribute 'window_menu'

I'm not sure what happened, since a few days ago I'd played with the branch and it was broken. I haven't had a chance to bisect it yet.

Basically, the point of putting this PR here is to see whether we can find the resources to finish up @Carreau's work to include it in 0.12. It's a large PR that had very nice functionality, and I would love to have his contribution in 0.12. But it's a lot of complex code that we can't just dump in there unless we're reasonably confident it's in good shape.

@epatters had given @Carreau already a ton of feedback, so you're the best positioned to gauge whether it's just missing a tiny bit of (doable) work or major effort that is not realistic in a short timeframe. I certainly won't take any action without your input.

In summary, before this can be merged, it needs:

- fixing the current brokenness, since the qt console won't even start.
- finishing up the remaining comments that were in-flight in the discussion for #813.
- any other checks/fixes that @epatters might deem necessary.

We'll see if it can be done before 0.12 or not...