cgbystrom/hoard — pull request #1 by cwholt (2011-10-17 22:47:47+00:00)
Title: initial findings and updates for hoard

hoard is pretty sweet. my initial findings are that it was a bit broken, so i fixed a few things:

added a .gitignore file

README.md
--------------------
* update -> updateMany
* comments about testing

test/hoard.test.coffee
-------------------------------
* updated reference to hoard.js location (in lib/)

src/hoard.coffee
------------------------
* out-of-the-box failing due to propagateLowerArchives being defined after it is called (is this a compiler specific issue?)
* copied propagateLowerArchives code from .updateManyArchive to .update with a small addition (like i said in comments, not an ideal implementation but just wanted to get working)
* try/catch for handling race condition with fs.read when offset is out of bounds (doesn't fix it, just handles it).

i am doing significant load testing using this library, and i fear there are many other exceptions that need to be handled, and i will try and fix, or at least handle, them as they present themselves. so far it's doing about 2000 requests per minute no problem, but when hitting the same hoard file there are periodic errors.

i also played around with adding a .last function to get the last value of the highest resolution archive, but it's not ideal so i reverted it.

thanks for the great library!