commontk/CTK — Issue #146: QtTesting and PythonQt should work nicely with find_package
Author: jcfr
Created: 2012-03-10 06:10:38+00:00
State: open

See https://github.com/finetjul/CTK/commit/1921eba1bd0bc3db9cff692495371b864fc3ab2e#commitcomment-1068559

* jcfr commented on 1921eba

To be explicit I would mention CMAKE_INSTALL_PREFIX in the commit title itself.

Regarding line 76, if IQtTesting_INSTALL_DIR is passed it should be sufficient and there is no need to pass QtTesting_DIR

Finally, the name of the topic seems off. I am assuming this just a throw-away topic made for cherry-picking and this would never be merged directly. If it's the case msvc-compilation-missing-export-macro is not the best name.

* finetjul commented on 1921eba

QtTesting_DIR is used in Slicer/CMakeLists.txt, maybe it's not useful.
Again, it should be decided if it makes sense to separate the "build" location from the "install" location. If it doesn't, then QtTesting_DIR is not useful.

Yes the topic is just here to be cherry-picked.

* jcfr commented on 1921eba

From the point of view of the client application (for example Slicer), it shouldn't really matter if the project is retrieved from a build or installed tree. In fact, each project should be discovered using find_package().

This would work if the variable _DIR is defined. It should be set with either the build or install dir. And since if should work if either the install or build tree. Using just the build tree should be enough.

Doing so would imply fixing the different CMake project we are working with.

* finetjul commented on 1921eba

Makes sense, however I'm not sure to understand yet how it would work with the packaging... Sounds like a fun post 4.1 project. I would be happy to help if needed.