eyandai/ivy-address-book — Issue #6: everything related with production code
Author: honnix
Created: 2012-03-06 10:38:14+00:00
State: open
Labels: bug, enhancement

* why

```java
if (phonematcher.matches()) {
return true;
}
return false;
```

could be `return phonematcher.matches();`, also, variable name is not according to java naming convention

* why starting a new thread to process task

* please generate serialVersionUID using Eclipse, not a default `1L`

* when defining exception constructor, it should at least allow me to put in message, or you should override `getMessage()` to return description from `ErrorCode`

* you should not assume where `phonebook.xml` is

* never return from `final` block

* there should be only one `return` statement in one method

* remove `public` modifier from interface, this i not needed