thiell/test — Issue #209: clush -bL traceback
Author: thiell
Created: 2012-03-03 16:36:37+00:00
State: open
Labels: Scripts

Just after 1.4.2 has been released, we noticed the following issue (with {{{-bL}}} only):

{{{
$ clush -bL -w node33 uname
Error in sys.excepthook:
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ClusterShell/CLI/Clush.py", line 624, in clush_excepthook
raise extype, value
TypeError: __init__() takes exactly 3 arguments (2 given)

Original exception was:
Traceback (most recent call last):
File "/usr/bin/clush", line 11, in
main()
File "/usr/lib/python2.6/site-packages/ClusterShell/CLI/Clush.py", line 844, in main
run_command(task, ' '.join(args), nodeset_base, timeout, display)
File "/usr/lib/python2.6/site-packages/ClusterShell/CLI/Clush.py", line 535, in run_command
handler = LiveGatherOutputHandler(display)
TypeError: __init__() takes exactly 3 arguments (2 given)
}}}

The fix is easy:
{{{
Index: lib/ClusterShell/CLI/Clush.py
===================================================================
--- lib/ClusterShell/CLI/Clush.py	(revision 488)
+++ lib/ClusterShell/CLI/Clush.py	(working copy)
@@ -532,7 +532,7 @@

if (display.gather or display.line_mode) and ns is not None:
if display.gather and display.line_mode:
- handler = LiveGatherOutputHandler(display)
+ handler = LiveGatherOutputHandler(display, ns)
else:
handler = GatherOutputHandler(display)
}}}

but the more important is to provide some non-reg tests for clush CLI scenarii with [milestone:1.4.3], a new bugfix release which should be released shortly to fix this and provide more tests.