cabennett85/gittest — Issue #1420: Broken Styling on Forgot Password Page
Author: cabennett85
Created: 2012-03-02 00:50:26+00:00
State: open

Looking at the code -

First off though - there's a function renderCSS(); We should avoid having css defined in the page where possible, and do it in some css file instead. We can do something like we do on BC, where we have some sort of css file aggregator. Or, put this in a separate file for now. Or, even better - do we need any "custom" styling here, or can we just use things that we already have? The css optimally loads in the head, so the page doesn't have to re-render, we get that by putting it in an included css file.

In this case, the css changes here are breaking the layout. Check out the header - the "Search" button is misaligned. I tried removing the css chunk, and that part rendered correctly. We're applying new rules to some pretty core elements here - content, label, input.text. If anything, this should be targeted via a class name. As it is defined now, it's affecting elements in the header and footer.