cabennett85/gittest — Issue #1016: Location missing from BC Cause About pages
Author: cabennett85
Created: 2012-03-02 00:30:59+00:00
State: open

The new about pages had different titles than the 'main' cause page, namely missing the location. We MUST be consistent with our naming of pages and subpages, or collisions will occur on mass scale, e.g, if 'Humane Society | Edmonton, AB' is the title on the main page, but 'Humane Society' (without the location) is the title on the about page, troubles!

I've fixed this by generalizing C-bel's location to title code (getLocationsForPageTitle) slightly so that it can be called from anywhere within the class. BETTER solution, as we add more subpages that can be indexed, is to have a 'get base title' function that provides an immutable (and single point of change/failure) that can serve as the 'base' for a title, with the specific parts of that page prepending it, e.g., for auctions, it might be "Auctions | $NPO_BASE_TITLE"

OTHERWISE, every time we build a public-facing NPO sub-page, we must make sure location is in it manually.