sardemff7/purple-libnotify-plus — Issue #1: Had to patch purple-libnotify+-utils.c to compile
Author: UnitedMarsupials
Created: 2012-02-29 20:02:55+00:00
State: open

While creating a FreeBSD port of your extension, I had to patch it to build against the version of libnotify installed by FreeBSD's devel/libnotify port (the first two hunks), and to add const-ification (the last hunk). Please, consider this for your next release. Thank you!

--- src/purple-libnotify+-utils.c 2011-10-29 17:03:41.000000000 -0400
+++ src/purple-libnotify+-utils.c 2012-02-29 13:59:30.000000000 -0500
@@ -22,7 +22,4 @@

#include
-#if ! NOTIFY_CHECK_VERSION(0,7,0)
-#include "libnotify-compat.h"
-#endif

#include "purple-libnotify+-utils.h"
@@ -183,5 +180,5 @@
}

- notification = notify_notification_new(title, es_body, NULL);
+ notification = notify_notification_new(title, es_body, NULL, NULL);

g_free(es_body);
@@ -199,6 +196,6 @@
GdkPixbuf *protocol_icon = NULL;
PurplePluginProtocolInfo *info;
- gchar *protoname = NULL;
- gchar *filename = NULL;
+ const gchar *protoname = NULL;
+ const gchar *filename = NULL;

buddy_icon = purple_buddy_get_icon(buddy);