mrdoob/three.js — Issue #1423: COLLADA vertices input semantic incorrectly handled due to pull request 1384 
Author: AddictArts
Created: 2012-02-28 21:55:07+00:00
State: open

The following commit
https://github.com/mrdoob/three.js/commit/20a8039660d97d01a18b393f81d96cc387d85e8b

from

https://github.com/mrdoob/three.js/pull/1384

Puts vertices element input (unshared) into the polylist or triangles element inputs (shared) which have an offset to an index. The vertices element input data source (unshared) do not have an offset to an index. Vertices element inputs semantics such as normals are per-vertex. They are not associated directly with a face, specifically polylist or triangle primitives. The commit hunk 3 puts all vertices input semantics into the polylist or triangle inputs. I don't believe it should do that. To overcome the missing offset mesh handlePrimitives was modified bypassing the offset when it should use the mandatory input semantic offset. Hunk 1 and 2 workaround the missing offset from the primitive input semantic.

If the desire was to overcome per-vertex normals not working in master, please see commit

https://github.com/mrdoob/three.js/commit/764b666166bf4e9672739c4950cca22b1048998f

From pull request

https://github.com/mrdoob/three.js/pull/1267