taqi/cleancode — Issue #39: avoid filling of the selectedCommits collection
Author: taqi
Created: 2012-02-27 07:41:14+00:00
State: open

Look at the first page (CommitSelection).
Here we check, if something has been selected via method "getSelectedCommits". This method is called from Listener, and after that we check "isEmpty".
This is the bad idea. Please, refactor it:

1. create method "isSomethingSelected", that should visit each row of the table, and will break cycle if at least one of them has been checked.
2. Modify method fillCodeReviewBuilder with getSelectedCommits here.