jordansissel/fpm — Issue #164: Regression in FPM 0.3.12: "path with spaces" in Thor gem 0.14.6 incorrectly handled
Author: benhutchison
Created: 2012-02-27 03:24:09+00:00
State: open

I've include relevant logs from two consecutive runs of our CI server, where it builds a RPM package for a Rails app. The code was unchanged, but the first succeeded while the second failed.

We believe that the difference was an upgrade of FPM minor version from 11 -> 12. Something in the upgrade caused it to incorrectly handle a test filename with spaces found in the Thor 0.14.6 gem.

(1) Successful run with 0.3.11

sudo gem install fpm --no-ri --no-rdoc
Successfully installed fpm-0.3.11
1 gem installed
cd /tmp && fpm -s dir -t rpm -a x86_64 -n studio -C /tmp/studio-1052 -v 130.1052 -d "ImageMagick" -d "mod_passenger" -d "rubygem(bundler)" -d"libmysqlclient.so.16()(64bit)" -d"libexslt.so.0()(64bit)" --description "REA Studio" --post-install /tmp/studio-1052/opt/rea/apps/studio/config/centos/rpm_post_install.sh .
..[snip]..
Processing files: studio-130.1052-1.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files /tmp/build-rpm-studio-130.1052-1.x86_64.rpm/BUILD
Wrote: /tmp/build-rpm-studio-130.1052-1.x86_64.rpm/SRPMS/studio-130.1052-1.src.rpm
Wrote: /tmp/build-rpm-studio-130.1052-1.x86_64.rpm/RPMS/x86_64/studio-130.1052-1.x86_64.rpm

(2) Failing run with 0.3.12

sudo gem install fpm --no-ri --no-rdoc
Successfully installed fpm-0.3.12
1 gem installed
cd /tmp && fpm -s dir -t rpm -a x86_64 -n studio -C /tmp/studio-1053 -v 130.1053 -d "ImageMagick" -d "mod_passenger" -d "rubygem(bundler)" -d"libmysqlclient.so.16()(64bit)" -d"libexslt.so.0()(64bit)" --description "REA Studio" --post-install /tmp/studio-1053/opt/rea/apps/studio/config/centos/rpm_post_install.sh .
..[snip]..
Processing files: studio-130.1053-1.x86_64
error: Two files on one line: /opt/rea/apps/studio/vendor/bundle/ruby/1.8/gems/thor-0.14.6/spec/fixtures/path
error: File must begin with "/": with
error: Two files on one line: /opt/rea/apps/studio/vendor/bundle/ruby/1.8/gems/thor-0.14.6/spec/fixtures/path
error: File must begin with "/": spaces