zaach/jison — Issue #86: Parsing CRLF based source files - should it work?
Author: kimptoc
Created: 2012-02-23 14:02:58+00:00
State: open

Hi,

I am using the Serenade JS framework, which uses Jison to parse its views. It seems to have an issue parsing views with CRLF line endings.

https://github.com/elabs/serenade.js/issues/24

From a quick scan of the Jison code, it seems that it is only checking for "\n" line endings.

I see a tweak to handle CRLF line endings in grammar files, but not in the actual parsing.

I am more than likely investigating this in the wrong place, but just in case I am not - I am thinking the parsing code should perhaps throw away "\r" characters or do a search/replace of "\r\n" for "\n" early or so...

Thanks in advance for any thoughts on this.
Chris