mate-desktop/mate-text-editor — Issue #2: recursive rule in makefile
Author: samtygier
Created: 2012-02-18 12:23:35+00:00
State: open

mate-text-editor/data/Makefile.am has a recursive rule, due to a change in https://github.com/mate-desktop/mate-text-editor/commit/e27c2373016af63918fb7ae540a26346513f4a98#diff-2

``` makefile
pluma.pc: pluma.pc
cp pluma.pc pluma.pc
```
On a clean git clone, this gives me the error:
```
make[2]: Entering directory `/var/tmp/mate/mate-text-editor/data'
Makefile:684: warning: overriding recipe for target `pluma.pc'
Makefile:368: warning: ignoring old recipe for target `pluma.pc'
LC_ALL=C /usr/bin/intltool-merge -d -u -c ../po/.intltool-merge-cache ../po pluma.desktop.in pluma.desktop
make[2]: Circular pluma.pc <- pluma.pc dependency dropped.
cp pluma.pc pluma.pc
cp: cannot stat `pluma.pc': No such file or directory
make[2]: *** [pluma.pc] Error 1
make[2]: *** Waiting for unfinished jobs....
Generating and caching the translation database
Merging translations into pluma.desktop.
make[2]: Leaving directory `/var/tmp/mate/mate-text-editor/data'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/mate/mate-text-editor'
make: *** [all] Error 2
```

Removing the rule from mate-text-editor/data/Makefile.am fixes the error. but i'd like someone to double check that that is the right thing to do.