sferik/rails_admin — Issue #987: Rails 3 defaults to HTML5, RailsAdmin forces XHTML in Haml
Author: jcoleman
Created: 2012-02-18 15:17:41+00:00
State: open

In commit 2359163804b5c2235ef62e869251ed5c108834e9 you force Haml to render XHTML strict which overrides the default of HTML5 in Rails 3. Unfortunately this forces the entire Rails project that is using RailsAdmin to be in that mode, and browsers render layouts differently between the two doc types. As I was upgrading RA from a (admittedly old) version, this change broke our layout in the browser on certain pages even though the stylesheets hadn't changed at all. Adding my own haml.rb initializer to force it back to HTML5 fixed rendering, but I'm not sure of the impact to RA.

What was the problem with XML parsing in XHR requests referenced in the commit? Is that still an issue? I commented out the change and ran the test suite and nothing was reported broken, but I wanted to see if we could trace this down if there still is an issue and perhaps find a better (non-globally impacting) fix.