offmessage/pyscrobbler — Issue #5: Merging back upstream changes from Sonata project 
Author: multani
Created: 2012-02-17 08:05:01+00:00
State: open

Hi,

Sonata is a Python/Gtk client to the Music Player Daemon (https://github.com/multani/sonata) which currently contains a copy of your audioscrobbler module, which has been imported circa February 2008 by the former maintainer of the project.

Since then, it has diverged a bit from your upstream version, and I would like to move those changes back from Sonata to here.

I had a quick look at the current differences, and this is what has been changed so far:

* code cleanup (PEP8-ification, trim trailing whitespaces)
* fix some encoding issues with non-utf8 locales
* use a MD5 password instead of a plain text one (?)
* store songs in a cache if they can't be send to the server (but I heard reports that it doesn't work in Sonata, though I'm not sure if the problem is in audioscrobbler.py or its usage by Sonata)
* a Python's logging support instead of hand-made log
* support for the 'now playing' API
* and there's an ongoing work on supporting Python 3

And the module from Sonata misses, of course, some stuffs you added later.

if you are interested, I'm willing to open one or more pull requests on your repository so that you can merge those changes here, and we can drop the custom module from Sonata to use this one instead.