porkcharsui/supersonic — Issue #6: random song buffer is filled even when shuffle mode is disabled
Author: timoreimann
Created: 2012-02-16 22:29:24+00:00
State: open

As described by myself in [this Subsonic bug report](http://sourceforge.net/tracker/?func=detail&aid=3466455&group_id=126265&atid=705132):

There is somewhat of a design flaw in the ShufflePlayBuffer class. On app startup, a buffer designated to hold a set of randomly retrieved songs is filled even when shuffle mode is disabled. Although the refill logic is triggered regularly through an ExecutorService job, subsequent runs do not affect performance in non-shuffle mode as the buffer won't be depleted then. Still, the initial download request is unneeded and may even affect user experience in low-bandwidth environments.

The logic should be changed such that the buffer is filled only when shuffle mode is actually enabled.