mininet/mininet — Issue #25: Refactor topo.py:class Edge(object)
Author: jvimal
Created: 2012-02-14 17:38:13+00:00
State: open

I really don't like the laundry list of parameters, especially the ones we added later on (enable_ecn, enable_red, use_hfsc, ...). It looks really really bad, though it's explicit. Also, maintaining that constructor is error prone!

A cleaner implementation would be to add a kwargs object to the constructor, and use something like __getattr__. The downside is bad readability---someone browsing the code would have no idea what options to pass. I think it's not a big deal, as we can document it.

Any thoughts?