MarkUsProject/Markus — Issue #648: deduction and interval should be required for penalty and penalty decay submission rules
Author: hoboman313
Created: 2012-02-11 02:45:26+00:00
State: open

Steps to reproduce:
- login as admin
- create a new one or modify an existing assignment
- under the "submission rules" tab select penalty formula or penalty decay formula
- do not fill in any of the fields and submit
- read the error message and notice how only the "hours" field is required to be filled in

It does not seem logical that only "hours" field is required for these two submission rules. For example, you could submit a penalty formula submission rule with only hours and a blank ( stored as null ) deduction field. I have not tested, but I assume that our code does not take into account and may break if we try to deduct "nil" every x hours.

Note that the hours/interval/deduction fields that I am referring to are the names of the fields in the db where these values are actually stored in the "periods" table. Currently only the hours field is enforced ( greater or equal to 0 ) in the periods model as that is the only field required for all three submission rules.