andris9/node-gettext — Issue #3: buffer_helpers.js should not monkey patch Buffer with equals
Author: ozten
Created: 2012-02-09 19:58:31+00:00
State: open

Howdy, thanks for an awesome project.

Here is a minimal test case that shows how node-gettext is incompatible with buffer tools (via a project called postprocess).
https://gist.github.com/1782430

Postprocess depends on buffertools. When loaded, in C++ code, it monkey patches Buffer to have an equals function, with different semantics than buffer_helpers.js monkey patch.

Suggestions:
* Perhaps use a unique name
* Not monkey patch Buffer

This issue was discovered downstream in
https://github.com/mozilla/browserid/issues/1080#issuecomment-3893917