PherricOxide/test — Issue #58: Google Hashmap Key Checking
Author: PherricOxide
Created: 2012-02-08 18:23:10+00:00
State: open
Labels: task

On multiple occurrences I've had components of Nova crash with obscure GoogleHashmap errors. The problem has almost always been the key being set to the "empty key" (usually 0/NULL).

Error checking should be added if there's a possibility that the key will be the empty key. For instance, I've seen this multiple times in the deserialization code. If you deserialize a port wrong and get "0", trying to continue will cause the program to crash with an obscure hard to debug error. It would be better to add checks and logging in cases like this, so the program can continue running and also be easier to debug when something does happen that causes such an error.