scrapmac/Auto-Complete — Issue #15: Incompatibility with OmnibarPlus
Author: Quicksaver
Created: 2012-02-05 19:46:01+00:00
State: open

I need to ask you a favor, there's a few incompatibilities with my own add-on Omnibar Plus. Most of them I have already fixed on my end and am about to release an updated version with them. However there's one I can't fix on my end. I was hoping you could do it in Auto-Complete.

It's very simple, in one of the "keydown" listeners for the gURLBar, just replace the line

375 if (lastSearch != gURLBar.textValue.trim() && !searchSuggestionDisplayed)

with

375 if (lastSearch != gURLBar.textValue.trim() && !searchSuggestionDisplayed && (!gURLBar.OmnibarPlus || !gURLBar.OmnibarPlus.organizing))

The reason for this is my handlers change the value of the address bar on certain conditions, so that statement would return true and reset the value of popup.selectedIndex to -1, thus preventing me from being able to delete the entry I want. This way, the index would be reset when that feature of Omnibar Plus is also enabled and since my handlers also reset the index of the popup appropriately, this doesn't cause any problems to Auto-Complete.