sciancio/connectionmanager — Issue #13: add tabs option for terminator
Author: dnotivol
Created: 2012-02-05 09:48:10+00:00
State: open

Hi sciancio,

It's a great extension, and a good point to include terminator as an alternative to native terminal.

Using it I saw it didn't open the connections in tabs when selecting terminator, and I saw in the wiki it's a limitation in the design. In the wiki you say terminator doesn't support tabs, but I'd say it does, at least in the release I'm using (0.95-1 in Ubuntu 11.10).

I was wondering if this feature could be included in a future release.
By the way, i just tried to edit the js code, and remove the restriction, and it is working for me. (Not sure if it should be the only change, or if this change can have collateral damages.)

Line 453, before:
if ( (this._menu_open_tabs) && (!this._terminator_as_terminal) ) {
Line 453, after:
if (this._menu_open_tabs) {

Thanks.