kriswallsmith/Buzz — Issue #41: Minimal PHP Version in composer.json
Author: ricardclau
Created: 2012-02-01 17:12:16+00:00
State: open

Hi

In composer.json Buzz is configured to require at least 5.3.0, but I think that there is one point where compatibility is broken and only works in 5.3.3.

In Buzz\Message\Request (line 91)

$info = parse_url($url);

if (false === $info) {
throw new \InvalidArgumentException(sprintf('The URL "%s" is invalid.', $url));
}

But looking at http://www.php.net/manual/en/function.parse-url.php Changelog

5.3.3	Removed the E_WARNING that was emitted when URL parsing failed.

And in my setup with PHP 5.3.2 Unit tests are broken here unless @parse_url($url) is done as it just gives a warning

What are your thoughts about this?