rainphp/raintpl3 — Issue #12: Inconsistent use of visibilitymodifiers
Author: suralc
Created: 2012-01-30 19:53:07+00:00
State: open

I just had a quick overview over the raintpl3 source and noticed that the php5 visibility modifiers are used in an inconsistent way. The methods declared in the Exception classes have them, while the core class omits them.

I think, they should be added to the core class, because of readability and consistency. Also there are some "protected static" and "static protected" methods, which is very annoying to read.

Also RainTPL::_compileTemplate uses $this in line 251, but is called in static context in line 158 in RainTPL::compileFile.