sfepy/sfepy — Issue #51: run-time type of term arguments
Author: rc
Created: 2012-01-30 10:24:53+00:00
State: open

Example:

there are groups of terms like:

dw_lin_elastic: argTypes = ('material', 'virtual', 'state')
dw_lin_elastic_r: argTypes = ('material', 'virtual', 'parameter')
d_lin_elastic: argTypes = ('material', 'parameter_1', 'parameter_2')

This should be unified, as the weak form in all those cases is only one.
The first two cases even share all the code, just the argTypes differ.

I am 100% for unifying the dw_* with dw_*_r, it should be easy. Not so sure
about d_*. Then the prefixes 'dw', 'd', etc. had to be united too, probably
to 'dw'.

Opinions?

Migrated from http://code.google.com/p/sfepy/issues/detail?id=47

earlier comments

robert.cimrman said, at 2008-07-04T10:01:11.000Z:

Unifying the dw_* with dw_*_r was trivial in terms of lines of code changed, but
finding the right places was not so obvious. Anyway, all *_r terms are now gone...

The remaining terms have not been touched. Now the next step (d_* terms) would mean
more editing. Is it worth right now?

robert.cimrman said, at 2008-09-18T10:49:05.000Z:

I have found an easy way to unify all terms sharing the integral forms. For example
dw_grad, dw_div, d_grad, d_div could be handled all by a single term. Now I am coding
a proof-of-concept.

ondrej.certik said, at 2008-09-18T11:46:05.000Z:

Excellent!

robert.cimrman said, at 2008-09-23T17:44:58.000Z:

It's in. For a sample term with this functionality see dw_piezo_coupling and its use
in input/piezo.py.

Now I will (gradually) remove unnecessary terms.

robert.cimrman said, at 2008-10-03T18:00:01.000Z:

Changeset http://hg.sympy.org/sfepy/rev/312b8baadda2 allows to unify also dw_, d_,
de_, dq_, ... forms of one term. The hyperelastic terms provide the sample
implementation.

I will close this issue after relevant terms are unified.

robert.cimrman said, at 2008-10-13T16:50:44.000Z:

Now, dw_stokes implements what was before in dw_grad, dw_div, d_div. See
input/navier_stokes.py file for an example.

robert.cimrman said, at 2008-10-21T08:28:03.000Z:

Together with Issue 59, dw_stokes, dw_biot, and dw_biot_th encompass all former Biot-
and Stokes-like terms (changeset http://hg.sympy.org/sfepy/rev/e2b43f0e4a76), let's
close this.