andrewplummer/TableGear — Issue #2: Suggestions
Author: CompuRoot
Created: 2012-01-29 19:03:54+00:00
State: open

1. Replace "getTable() ?>

getJavascript("jquery") ?>

to:

getTable(); ?>

getJavascript("jquery"); ?>

in the "index.php"

3. Remove BOM (0xEF) simbol in begining of files: (!!! Perhaps editor leaved it)
stylesheets/tablegear.css
javascripts/tablegear-jquery.js
include/tablegear.php

4. Change dangerous permissions on files from from 700 to 644
find ./ -type f -exec chmod 644 {} \;

5. Update pagination options in index.php (add first and last page)
$options["pagination"]["first"] = "first"; // "first" link will be shown.
$options["pagination"]["last"] = "last"; // "last" link will be shown.

6. IMHO, No point to allow select image or character for delete action because CSS always load first predefined image for that. It lead to overlapping over CSS image if one added those option(s).

7. Initial adding of value is unpossible in case of
$options["selects"] = array("Sex" => array("Male" => "M", "Female" => "F"));
One need to add record first then switch "Male" to "Female" first, then back again to "Male" in case if "Male" needed.

8. For intranet use
8.1 download jQuery

cur_dir="$(pwd)"
mkdir -m 755 -v -p ./javascripts/ajax/libs/jquery/1.4.2 ;
cd ./javascripts/ajax/libs/jquery/1.4.2 ;
wget -v 'http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js' ;
cd "${cur_dir}" ;
8.2 Replace link

to:

in index.php

9. Optional: Change newline from DOS to Unix in index.php
mv index.php index_dos.php
tr -d '\r' < index_dos.php > index.php