habari/habari — Issue #285: Arguments with default values should be at the end of the argument list
Author: mikelietz
Created: 2012-01-28 00:25:28+00:00
State: open

in https://github.com/habari/system/blob/master/classes/theme.php#L1304 and https://github.com/habari/system/blob/master/classes/theme.php#L1323 there is an argument with a default value before one without any. Codesniffer regards this as a blocker, though it's not quite that serious.

Following $value through to Stack::Add an empty value would end up shown on the page. Some sensible handling of this eventuality (or a mere rearrangement of the arguments) might be in order.