alexreisner/geocoder — Issue #167: In lookups/base, invalid JSON needs to be rescued for ActiveSupport::JSON
Author: galvinhsiu
Created: 2012-01-28 19:38:17+00:00
State: open

Currently when not using ActiveSupport::JSON,

The barebones json parse call gets rescued and throws out the following warning:

"Geocoding API's response was not valid JSON."

However, if ActiveSupport::JSON is detected, ActiveSupport::JSON call runs the parse w/o any begin / rescue blocks. We ran into this issue when running db migrations within rails w/ the Yahoo provider sporadically throwing out parse errors, stopping our db migrations dead in its tracks.

I will be submitting a pull request that ensures that the json.parse calls and activesupport::json.parse call are consistent.