cgeo/c-geo-opensource — Issue #1038: use standard preferences location, use right preference types, externalize preference keys
Author: Bananeweizen
Created: 2012-01-25 07:53:32+00:00
State: open

While I started working on the preference activity, I found that we can avoid several issues there by first doing a refactoring of the existing settings, related to 2 points:

* We don't use the standard location to save the preferences, which makes it unnecessarily hard to get some things running at all (like the preference manager of the preferenceActivity).
* We sometimes use integer types for boolean preferences. As the preference activity expects boolean values for boolean preferences, this might lead to real problems. I have no clue whether it can deal with wrong data types or just looses the values when reading the preferences.

Therefore I will first do a refactoring which cleans those 2 issues. Additionally it might be a good idea to externalize the preference key names into a String resource, because then we can access the names from code and from the preference activity XML declaration without duplication.