hpcc-systems/HPCC-Platform — Issue #1337: Control:lockDali call should be renamed
Author: afleury
Created: 2012-01-23 20:49:09+00:00
State: open

In testing I noticed that it looked like control:lock was intercepting this call. Since this method never worked it would probably not make sense to rewrite the control query parsing (unless we plan on making more control commands that start with 'lock' )

Recommend change the following lines and moving them to the correct case positioning in ccdstate if possible:

\HPCC-Platform\roxie\ccd\ccddali.cpp(342): if (topology && !topology->getPropBool("@connectDali", false))
\HPCC-Platform\roxie\ccd\ccdstate.cpp(1736): else if (stricmp(queryName, "control:disconnectDali")==0)
\HPCC-Platform\roxie\ccd\ccdstate.cpp(1740): topology->setPropBool("@connectDali", true);
\HPCC-Platform\roxie\ccd\ccdstate.cpp(2208): else if (stricmp(queryName, "control:connectDali")==0)
\HPCC-Platform\roxie\ccd\ccdstate.cpp(2212): topology->setPropBool("@connectDali", false);

If we want to leave the topology option name alone to save rewriting documentation and backward compatibility then just change these please:

\HPCC-Platform\roxie\ccd\ccdstate.cpp(1736): else if (stricmp(queryName, "control:disconnectDali")==0)
\HPCC-Platform\roxie\ccd\ccdstate.cpp(2208): else if (stricmp(queryName, "control:connectDali")==0)