sebbacon/alaveteli — Issue #361: Many order-dependent test failures
Author: robinhouston
Created: 2012-01-23 21:54:57+00:00
State: open

Many of the spec tests will fail if run in the wrong order. This is presumably due in many cases to inadequate test isolation, though this exercise has already uncovered one potentially serious bug (https://github.com/mysociety/commonlib/commit/c200fcbb73981113fcb2ccd132e1a2b386823c6b)

The following list of test failures was generated by https://github.com/sebbacon/alaveteli/blob/develop/script/spec-all-pairs

* FAILED: spec/controllers/admin_general_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/admin_general_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/admin_public_body_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/admin_public_body_controller_spec.rb spec/controllers/request_controller_spec.rb
* FAILED: spec/controllers/admin_request_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/admin_request_controller_spec.rb spec/models/xapian_spec.rb
* FAILED: spec/controllers/admin_track_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/admin_track_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/admin_general_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/admin_public_body_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/admin_request_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/admin_track_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/application_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/comment_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/help_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/public_body_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/request_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/request_game_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/services_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/track_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/controllers/user_controller_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/helpers/link_to_helper_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/integration/errors_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/integration/search_request_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/integration/view_request_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/lib/i18n_interpolation.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/lib/sendmail_return_path_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/lib/timezone_fixes_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/lib/tmail_extensions_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/application_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/censor_rule_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/contact_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/contact_validator_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/customstates.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/foi_attachment_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/has_tag_string_tag_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/holiday_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/incoming_message_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/info_request_event_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/info_request_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/outgoing_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/outgoing_message_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/post_redirect_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/profile_photo_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/public_body_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/raw_email_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/request_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/track_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/track_thing_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/track_things_sent_email_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/user_info_request_sent_alert_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/user_mailer_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/user_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/models/xapian_spec.rb
* FAILED: spec/controllers/admin_user_controller_spec.rb spec/script/handle-mail-replies_spec.rb
* FAILED: spec/controllers/application_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/application_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/application_controller_spec.rb spec/script/handle-mail-replies_spec.rb
* FAILED: spec/controllers/comment_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/general_controller_spec.rb spec/controllers/admin_general_controller_spec.rb
* FAILED: spec/controllers/general_controller_spec.rb spec/script/handle-mail-replies_spec.rb
* FAILED: spec/controllers/help_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/controllers/services_controller_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/controllers/user_controller_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/helpers/link_to_helper_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/integration/view_request_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/models/contact_validator_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/models/profile_photo_spec.rb
* FAILED: spec/controllers/request_controller_spec.rb spec/models/track_thing_spec.rb
* FAILED: spec/controllers/services_controller_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/controllers/services_controller_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/controllers/services_controller_spec.rb spec/controllers/request_controller_spec.rb
* FAILED: spec/controllers/user_controller_spec.rb spec/script/handle-mail-replies_spec.rb
* FAILED: spec/helpers/link_to_helper_spec.rb spec/controllers/admin_user_controller_spec.rb
* FAILED: spec/helpers/link_to_helper_spec.rb spec/controllers/general_controller_spec.rb
* FAILED: spec/helpers/link_to_helper_spec.rb spec/controllers/request_controller_spec.rb