Jasig/phpCAS — Issue #20: cas server callback handling needs improvement
Author: jfritschi
Created: 2012-01-21 11:24:53+00:00
State: open
Labels: Minor Bug

Some parts of the callback handling from the CAS server needs improvement. The code is not optimal which i realized while investigating #19.

The callback handling is duplicated in isAuthenticated() on top of wasPreviouslyAuthenticated(). This would skhip the rebroadcast in certain instances. This is minor bug.

I also believe that the callback might even be handled in the constructor and not in previously authenticated. But i'm currently a bit uncertain if i'm missing something...

@adamfranco: Do you have an idea if moving the callback handling into the constructor (where the detection is already done) might pose any problem i'm currently overlooking?