murraymeehan/marsyas — Issue #1: in src/marsyas/MarSystem.h: DEPRECIATED tag used without depreciating functions 
Author: murraymeehan
Created: 2012-01-20 05:23:31+00:00
State: open

Also the use of ctrl or Control in function names in MarSystem.h is inconsistent. All *ctrl functions should be renamed to *Control and old functions should be depreciated like so:

examples of doing depreciation right:
DEPRECATED(bool updctrl(MarControlPtr control, MarControlPtr newcontrol, bool upd = true))
{
return updControl(control, newcontrol, upd);
}

And not like so:

examples of doing depreciation wrong:
DEPRECATED(bool updctrl(const char *cname, MarControlPtr newcontrol, bool upd = true))
{
MarControlPtr control = getControl(cname);
if (control.isInvalid())
{
MRSWARN("MarSystem::updctrl - " + std::string(cname) + " is an invalid control @ " + getAbsPath());
return false;
}
return updControl(control, newcontrol, upd);
}