globocom/thumbor — Issue #60: "extension"/image type must be set in engine context by the loader module
Author: dhardy92
Created: 2012-01-18 17:07:07+00:00
State: open

Hello,

I have some probleme with http_loader with url of images without extension or extension like ".php?foo=bar"
The engine is unable to determine witch type of image format it is addressing. In this case the HTTP header should be helpfull Content-Type: image/png, Content-Type: image/jpeg, Content-Type: image/gif
Only file_loader should base it on the file extension (or maybe first bytes of the file like the unix "file" command)

The loader is unable to set the extension (or some sort of imageType var) in context of image engine and I think it should do.

loader module should return image raw data and image type.
I am not feeling easy with python and the code to do so much refactoring. That's why I am not doing a pull request for now.

Hope I am clear enougth :)

Cheers,
--
Damien